linux-kernel - Re: [PATCH] aio: add missing dcache flush

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 19 May 2021 14:40:22 -0400
From:   Jeff Moyer <jmoyer@...hat.com>
To:     Alexey Dobriyan <adobriyan@...il.com>
Cc:     bcrl@...ck.org, akpm@...ux-foundation.org, linux-aio@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] aio: add missing dcache flush

Alexey Dobriyan <adobriyan@...il.com> writes:

> Ring page is mapped by kernel and updated so dcache must be flushed.
>
> Signed-off-by: Alexey Dobriyan <adobriyan@...il.com>
> ---
>
> 	Not tested but the usage looks fishy.
>
>  fs/aio.c |    1 +
>  1 file changed, 1 insertion(+)
>
> --- a/fs/aio.c
> +++ b/fs/aio.c
> @@ -653,6 +653,7 @@ static int ioctx_add_table(struct kioctx *ctx, struct mm_struct *mm)
>  					ring = kmap_atomic(ctx->ring_pages[0]);
>  					ring->id = ctx->id;
>  					kunmap_atomic(ring);
> +					flush_dcache_page(ctx->ring_pages[0]);
>  					return 0;
>  				}
>  
>

Sorry for the late review.

Reviewed-by: Jeff Moyer <jmoyer@...hat.com>