linux-kernel - Re: [PATCH v1 2/2] ASoC: tegra: Unify ASoC machine drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210519200902.GJ4224@sirena.org.uk>
Date:   Wed, 19 May 2021 21:09:02 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Dmitry Osipenko <digetx@...il.com>
Cc:     Rob Herring <robh@...nel.org>,
        Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Takashi Iwai <tiwai@...e.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Ion Agorria <ion@...rria.com>,
        Svyatoslav Ryhel <clamor95@...il.com>,
        Frank Rowand <frowand.list@...il.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        linux-tegra@...r.kernel.org, devicetree@...r.kernel.org,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 2/2] ASoC: tegra: Unify ASoC machine drivers

On Tue, May 18, 2021 at 11:16:48PM +0300, Dmitry Osipenko wrote:
> 18.05.2021 21:34, Mark Brown пишет:

> > It's generally the clocking configuration, things with fancy clock trees
> > don't play so nicely with generic systems where we want to configure
> > them at runtime, or things with complex routing in the CPU where we
> > only recently started getting bindings that were functional enough to
> > use.  Tegra is fairly complex internally.

> This is true, but still it's more optimal to use flags in a single
> common driver for the minor differences rather than to duplicate 90% of
> the code. In practice majority of tegra boards are derived from the same
> reference design, thus the h/w configurations are mostly the same.

If you can do it yes, though some of the CODECs can have sufficiently
interesting clocking to make it useful to do something different - not
sure if any of those are upstream though, WM8903 ought to with the right
board I think.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)