linux-kernel - Re: [PATCH] crypto: ccp - Fix a resource leak in an error handling path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YKV7YkyFKQYY9WE7@AUS-LX-JohALLEN.amd.com>
Date:   Wed, 19 May 2021 15:56:02 -0500
From:   John Allen <john.allen@....com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     thomas.lendacky@....com, herbert@...dor.apana.org.au,
        davem@...emloft.net, gary.hook@....com, brijesh.singh@....com,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] crypto: ccp - Fix a resource leak in an error handling
 path

On Sun, May 16, 2021 at 08:58:04AM +0200, Christophe JAILLET wrote:
> If an error occurs after calling 'sp_get_irqs()', 'sp_free_irqs()' must be
> called as already done in the error handling path.
> 
> Fixes: f4d18d656f88 ("crypto: ccp - Abstract interrupt registeration")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

Acked-by: John Allen <john.allen@....com>

> ---
>  drivers/crypto/ccp/sp-pci.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/crypto/ccp/sp-pci.c b/drivers/crypto/ccp/sp-pci.c
> index f468594ef8af..6fb6ba35f89d 100644
> --- a/drivers/crypto/ccp/sp-pci.c
> +++ b/drivers/crypto/ccp/sp-pci.c
> @@ -222,7 +222,7 @@ static int sp_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>  		if (ret) {
>  			dev_err(dev, "dma_set_mask_and_coherent failed (%d)\n",
>  				ret);
> -			goto e_err;
> +			goto free_irqs;
>  		}
>  	}
>  
> @@ -230,10 +230,12 @@ static int sp_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>  
>  	ret = sp_init(sp);
>  	if (ret)
> -		goto e_err;
> +		goto free_irqs;
>  
>  	return 0;
>  
> +free_irqs:
> +	sp_free_irqs(sp);
>  e_err:
>  	dev_notice(dev, "initialization failed\n");
>  	return ret;
> -- 
> 2.30.2
>