linux-kernel - Re: [PATCH 7/7] gpio/rockchip: drop irq_gc_lock/irq_gc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 20 May 2021 01:26:42 +0200
From:   Heiko Stübner <heiko@...ech.de>
To:     linus.walleij@...aro.org, robh+dt@...nel.org,
        Jianqun Xu <jay.xu@...k-chips.com>
Cc:     linux-gpio@...r.kernel.org, linux-rockchip@...ts.infradead.org,
        linux-kernel@...r.kernel.org, Jianqun Xu <jay.xu@...k-chips.com>
Subject: Re: [PATCH 7/7] gpio/rockchip: drop irq_gc_lock/irq_gc_unlock for irq set type

Am Montag, 10. Mai 2021, 08:37:34 CEST schrieb Jianqun Xu:
> There has spin lock for irq set type already, so drop irq_gc_lock and
> irq_gc_unlock.
> 
> Signed-off-by: Jianqun Xu <jay.xu@...k-chips.com>

I've looked that up, and yes the irq_gc_lock stuff really seems to be
redundant when there is already another spinlock in place, so

Reviewed-by: Heiko Stuebner <heiko@...ech.de>