linux-kernel - Re: [PATCH] gpio: gpio-stmpe: fully use convert probe to device-managed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 20 May 2021 01:55:00 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Alexandru Ardelean <aardelean@...iqon.com>
Cc:     "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        alexandre.torgue@...s.st.com,
        Maxime Coquelin <mcoquelin.stm32@...il.com>
Subject: Re: [PATCH] gpio: gpio-stmpe: fully use convert probe to device-managed

On Sun, May 16, 2021 at 8:14 AM Alexandru Ardelean
<aardelean@...iqon.com> wrote:

> The driver doesn't look like it can be built as a kmod, so leaks cannot
> happen via a rmmod mechanism.
> The remove hook was removed via commit 3b52bb960ec6 ("gpio: stmpe: make
> it explicitly non-modular").
>
> The IRQ is registered via devm_request_threaded_irq(), making the driver
> only partially device-managed.
>
> In any case all resources should be made device-managed, mostly as a good
> practice. That way at least the unwinding on error is happening in reverse
> order (as the probe).
>
> This change also removes platform_set_drvdata() since the information is
> never retrieved to be used in the driver.
>
> Signed-off-by: Alexandru Ardelean <aardelean@...iqon.com>

Nice!
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij