linux-kernel - Re: [PATCH rdma-rc v1] RDMA/core: Sanitize WQ state received from the userspace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YKShxoNM9Az8GQ0q@unreal>
Date:   Wed, 19 May 2021 08:27:34 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     "Saleem, Shiraz" <shiraz.saleem@...el.com>
Cc:     Doug Ledford <dledford@...hat.com>,
        Jason Gunthorpe <jgg@...dia.com>,
        Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        Yishai Hadas <yishaih@...dia.com>
Subject: Re: [PATCH rdma-rc v1] RDMA/core: Sanitize WQ state received from
 the userspace

On Tue, May 18, 2021 at 10:07:38PM +0000, Saleem, Shiraz wrote:
> > Subject: [PATCH rdma-rc v1] RDMA/core: Sanitize WQ state received from the
> > userspace
> > 
> > From: Leon Romanovsky <leonro@...dia.com>
> > 
> > The mlx4 and mlx5 implemented differently the WQ input checks.
> > Instead of duplicating mlx4 logic in the mlx5, let's prepare the input in the central
> > place.
> 
> Maybe some more verbiage about what the bug was in mlx5 that prompted this patch would
> be good since this an -rc fix.

It can go to -next too, the bug is that we didn't check for validity of
state input in mlx5. It is not real bug because our FW checked that, but
still worth to fix.

I'll add this.

Thanks

> 
> Shiraz