linux-kernel - Re: [PATCH -next] irqchip/mbigen: fix compile warning when CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 19 May 2021 08:49:54 +0100
From:   Marc Zyngier <maz@...nel.org>
To:     Yang Yingliang <yangyingliang@...wei.com>
Cc:     linux-kernel@...r.kernel.org, tglx@...utronix.de
Subject: Re: [PATCH -next] irqchip/mbigen: fix compile warning when
 CONFIG_ACPI is disabled

On 2021-05-19 06:04, Yang Yingliang wrote:
> Fix the following compile warning:
> 
>   drivers/irqchip/irq-mbigen.c:372:36: warning: ‘mbigen_acpi_match’
> defined but not used [-Wunused-const-variable=]
>    static const struct acpi_device_id mbigen_acpi_match[] = {
> 
> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>
> ---
>  drivers/irqchip/irq-mbigen.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/irqchip/irq-mbigen.c 
> b/drivers/irqchip/irq-mbigen.c
> index 2cb45c6b8501..f565317a3da3 100644
> --- a/drivers/irqchip/irq-mbigen.c
> +++ b/drivers/irqchip/irq-mbigen.c
> @@ -273,6 +273,12 @@ static int mbigen_of_create_domain(struct
> platform_device *pdev,
>  }
> 
>  #ifdef CONFIG_ACPI
> +static const struct acpi_device_id mbigen_acpi_match[] = {
> +	{ "HISI0152", 0 },
> +	{}
> +};
> +MODULE_DEVICE_TABLE(acpi, mbigen_acpi_match);
> +
>  static int mbigen_acpi_create_domain(struct platform_device *pdev,
>  				     struct mbigen_device *mgn_chip)
>  {
> @@ -369,12 +375,6 @@ static const struct of_device_id mbigen_of_match[] 
> = {
>  };
>  MODULE_DEVICE_TABLE(of, mbigen_of_match);
> 
> -static const struct acpi_device_id mbigen_acpi_match[] = {
> -	{ "HISI0152", 0 },
> -	{}
> -};
> -MODULE_DEVICE_TABLE(acpi, mbigen_acpi_match);
> -
>  static struct platform_driver mbigen_platform_driver = {
>  	.driver = {
>  		.name		= "Hisilicon MBIGEN-V2",

Is it actually a thing to have mbigen without ACPI? As far as I can
tell, all the mbigen-equipped machines in existence use ACPI.

Thanks,

         M.
-- 
Jazz is not dead. It just smells funny...