linux-kernel - Re: [bug report] Memory leak from acpi_ev_install_space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3ab18796-f8b5-9498-a31a-5dfd21059ebb@huawei.com>
Date:   Wed, 19 May 2021 09:20:45 +0100
From:   John Garry <john.garry@...wei.com>
To:     "Kaneda, Erik" <erik.kaneda@...el.com>,
        "Rafael J. Wysocki" <rafael@...nel.org>
CC:     ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Len Brown <lenb@...nel.org>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        chenxiang <chenxiang66@...ilicon.com>
Subject: Re: [bug report] Memory leak from acpi_ev_install_space_handler()

On 18/05/2021 22:48, Kaneda, Erik wrote:
> Hi John,
> 
>> I don't mind looking further if requested.
> Someone else reported this as well. 

I noticed. By chance, it was my close colleague Xiang Chen.

Could you try the patch below? I think it might help fix this issue..

It looks like the same problem, and you provided the same solution, so 
we can look to test it.

Thanks

> 
> Thanks,
> Erik
> 
> diff --git a/drivers/acpi/acpica/utdelete.c b/drivers/acpi/acpica/utdelete.c
> index 624a26794d55..e5ba9795ec69 100644
> --- a/drivers/acpi/acpica/utdelete.c
> +++ b/drivers/acpi/acpica/utdelete.c
> @@ -285,6 +285,14 @@ static void acpi_ut_delete_internal_obj(union acpi_operand_object *object)
>                  }
>                  break;
> 
> +       case ACPI_TYPE_LOCAL_ADDRESS_HANDLER:
> +
> +               ACPI_DEBUG_PRINT((ACPI_DB_ALLOCATIONS,
> +                                 "***** Address handler %p\n", object));
> +
> +               acpi_os_delete_mutex(object->address_space.context_mutex);
> +               break;
> +
>          default:
> 
>                  break;
>