linux-kernel - Re: [PATCH 6/6] dt-bindings: i2c: maxim,max9286: Use the i2c-mux.yaml schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 19 May 2021 04:18:09 +0300
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Rob Herring <robh@...nel.org>
Cc:     devicetree@...r.kernel.org, Peter Rosin <peda@...ntia.se>,
        Wolfram Sang <wsa@...nel.org>, linux-kernel@...r.kernel.org,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Jacopo Mondi <jacopo+renesas@...ndi.org>,
        Kieran Bingham <kieran.bingham+renesas@...asonboard.com>,
        Kishon Vijay Abraham I <kishon@...com>,
        Lee Jones <lee.jones@...aro.org>,
        Niklas Söderlund 
        <niklas.soderlund+renesas@...natech.se>,
        Roger Quadros <rogerq@...com>,
        Jonathan Cameron <jic23@...nel.org>
Subject: Re: [PATCH 6/6] dt-bindings: i2c: maxim,max9286: Use the
 i2c-mux.yaml schema

Hi Rob,

Thank you for the patch.

On Tue, May 18, 2021 at 06:28:58PM -0500, Rob Herring wrote:
> Use the i2c-mux.yaml schema in the maxim,max9286 binding schema. With this,
> several properties can be dropped as they are defined in i2c-mux.yaml
> already.
> 
> Cc: Jacopo Mondi <jacopo+renesas@...ndi.org>
> Cc: Kieran Bingham <kieran.bingham+renesas@...asonboard.com>
> Cc: Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>
> Cc: Niklas Söderlund <niklas.soderlund+renesas@...natech.se>
> Signed-off-by: Rob Herring <robh@...nel.org>

Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

> ---
>  .../bindings/media/i2c/maxim,max9286.yaml     | 23 +++----------------
>  1 file changed, 3 insertions(+), 20 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml b/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml
> index ee16102fdfe7..02f656e78700 100644
> --- a/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml
> @@ -111,17 +111,10 @@ properties:
>  
>    i2c-mux:
>      type: object
> +    $ref: /schemas/i2c/i2c-mux.yaml#
> +    unevaluatedProperties: false
>      description: |
> -      Each GMSL link is modelled as a child bus of an i2c bus
> -      multiplexer/switch, in accordance with bindings described in
> -      Documentation/devicetree/bindings/i2c/i2c-mux.txt.
> -
> -    properties:
> -      '#address-cells':
> -        const: 1
> -
> -      '#size-cells':
> -        const: 0
> +      Each GMSL link is modelled as a child bus of an i2c bus multiplexer/switch.
>  
>      patternProperties:
>        "^i2c@[0-3]$":
> @@ -133,12 +126,6 @@ properties:
>            channels.
>  
>          properties:
> -          '#address-cells':
> -            const: 1
> -
> -          '#size-cells':
> -            const: 0
> -
>            reg:
>              description: The index of the GMSL channel.
>              maxItems: 1
> @@ -173,10 +160,6 @@ properties:
>  
>              additionalProperties: false
>  
> -        additionalProperties: false
> -
> -    additionalProperties: false
> -
>  required:
>    - compatible
>    - reg

-- 
Regards,

Laurent Pinchart