[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20210519111107.GC24621@duo.ucw.cz>
Date: Wed, 19 May 2021 13:11:07 +0200
From: Pavel Machek <pavel@....cz>
To: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
Cc: linuxarm@...wei.com, mauro.chehab@...wei.com,
gregkh@...uxfoundation.org, linux-doc@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-leds@...r.kernel.org
Subject: Re: [PATCH v2 00/17] Adding support for controlling the leds found
on Intel NUC
Hi!
> Some models come with single colored or dual-colored LEDs, but high end models
> have RGB LEDs.
>
> Programming them can ether be done via BIOS or by the OS, however, BIOS settings
> are limited. So, the vendor offers a Windows application that allows to fully use the
> functionality provided by the firmware/hardware.
I'm not sure why you are submitting v2 in the middle of interface
discussion.
Marek and I are saying the same thing -- this needs to use close to
existing APIs.
If you want to get something merged quickly, please submit basic
functionality only (toggling the LED on/off) that completely fits
existing APIs. We can review that.
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)
Powered by blists - more mailing lists