linux-kernel - Re: [PATCH] brcmsmac: mac80211_if: Fix a resource leak in an error handling path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3b96aa02-869c-4663-1c63-759d058b8744@broadcom.com>
Date:   Wed, 19 May 2021 14:39:08 +0200
From:   Arend van Spriel <arend.vanspriel@...adcom.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        aspriel@...il.com, franky.lin@...adcom.com,
        hante.meuleman@...adcom.com, chi-hsien.lin@...ineon.com,
        wright.feng@...ineon.com, chung-hsien.hsu@...ineon.com,
        davem@...emloft.net, kvalo@...eaurora.org, kuba@...nel.org
Cc:     linux-wireless@...r.kernel.org,
        brcm80211-dev-list.pdl@...adcom.com,
        SHA-cyfmac-dev-list@...ineon.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] brcmsmac: mac80211_if: Fix a resource leak in an error
 handling path



On 12-05-2021 22:58, Christophe JAILLET wrote:
> If 'brcms_attach()' fails, we must undo the previous 'ieee80211_alloc_hw()'
> as already done in the remove function.

Acked-by: Arend van Spriel <arend.vanspriel@...adcom.com>
> Fixes: 5b435de0d786 ("net: wireless: add brcm80211 drivers")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
>   .../wireless/broadcom/brcm80211/brcmsmac/mac80211_if.c    | 8 +++++++-
>   1 file changed, 7 insertions(+), 1 deletion(-)