linux-kernel - Re: [PATCH] hungtask: add filter kthread/check comm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YKUNSkG5saX2QXhf@dhcp22.suse.cz>
Date:   Wed, 19 May 2021 15:06:18 +0200
From:   Michal Hocko <mhocko@...e.com>
To:     chenguanyou <chenguanyou9338@...il.com>
Cc:     linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
        keescook@...omium.org, lukas.bulwahn@...il.com, vbabka@...e.cz,
        gpiccoli@...onical.com, chenguanyou <chenguanyou@...omi.com>
Subject: Re: [PATCH] hungtask: add filter kthread/check comm

On Wed 19-05-21 20:13:25, chenguanyou wrote:
> Some kernel threads are always in D state, when we enable hung_task,
> it will misjudge, we should skip these to narrow the scope.

Why they are in the D state in the first place?

Also you are proposing a new user interface which would need to be
maintained for ever. This means that any such a proposal has to be very
carefully justified. Always make sure to cc linux-api mailing list in
these cases.

>From the (not much) information you have provided this interface seems
more like a workaround for buggy code so far.
-- 
Michal Hocko
SUSE Labs