linux-kernel - Re: [PATCH] regulator: Check ramp_delay_table for regulator_set_ramp_delay

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210519131626.GE4224@sirena.org.uk>
Date:   Wed, 19 May 2021 14:16:26 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Axel Lin <axel.lin@...ics.com>
Cc:     Matti Vaittinen <matti.vaittinen@...rohmeurope.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regulator: Check ramp_delay_table for
 regulator_set_ramp_delay_regmap

On Wed, May 19, 2021 at 03:50:24PM +0800, Axel Lin wrote:

> +	if (!rdev->desc->n_ramp_values || !rdev->desc->ramp_delay_table) {
> +		WARN_ON(!rdev->desc->n_ramp_values || !rdev->desc->ramp_delay_table);

You can write "if (WARN_ON(..." there and it'll DTRT, though I'm never
sure it's great for readability.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)