linux-kernel - Re: [PATCH -next resend] scsi: hisi_sas: drop free_irq of devm_request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <351f5f06-e992-d22a-5ad5-d3d749155ae0@huawei.com>
Date:   Wed, 19 May 2021 14:17:13 +0100
From:   John Garry <john.garry@...wei.com>
To:     Yang Yingliang <yangyingliang@...wei.com>,
        <linux-kernel@...r.kernel.org>, <linux-scsi@...r.kernel.org>
CC:     <jejb@...ux.ibm.com>, <martin.petersen@...cle.com>,
        <chenxiang66@...ilicon.com>, <luojiaxing@...wei.com>
Subject: Re: [PATCH -next resend] scsi: hisi_sas: drop free_irq of
 devm_request_irq allocated irq

On 19/05/2021 14:05, Yang Yingliang wrote:
> irq allocated with devm_request_irq should not be freed using
> free_irq, because doing so causes a dangling pointer, and a
> subsequent double free.
> 
> Reported-by: Hulk Robot<hulkci@...wei.com>
> Signed-off-by: Yang Yingliang<yangyingliang@...wei.com>
> ---

Acked-by: John Garry <john.garry@...wei.com>