linux-kernel - Re: [PATCH] soc: samsung: pmu: fix BUT->BIT macro typo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 19 May 2021 20:06:02 +0530
From:   Alim Akhtar <alim.akhtar@...il.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
Cc:     linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org,
        open list <linux-kernel@...r.kernel.org>,
        Alim Akhtar <alim.akhtar@...sung.com>
Subject: Re: [PATCH] soc: samsung: pmu: fix BUT->BIT macro typo

Hello Krzysztof

On Mon, May 17, 2021 at 7:59 PM Krzysztof Kozlowski
<krzysztof.kozlowski@...onical.com> wrote:
>
> The macro EXYNOS5_USE_STANDBYWFI_ARM_CORE1 should use BIT, not BUT.  Fix
> does not have real effect as the macro is not used in the code.
>
Can we consider removing this? As this is not used in code.

> Fixes: af2e0a0754ac ("ARM: EXYNOS: Add PMU support for exynos5420")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
> ---


>  include/linux/soc/samsung/exynos-regs-pmu.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/soc/samsung/exynos-regs-pmu.h b/include/linux/soc/samsung/exynos-regs-pmu.h
> index fc9250fb3133..4bfd9a210da2 100644
> --- a/include/linux/soc/samsung/exynos-regs-pmu.h
> +++ b/include/linux/soc/samsung/exynos-regs-pmu.h
> @@ -613,7 +613,7 @@
>
>  /* For EXYNOS_CENTRAL_SEQ_OPTION */
>  #define EXYNOS5_USE_STANDBYWFI_ARM_CORE0                       BIT(16)
> -#define EXYNOS5_USE_STANDBYWFI_ARM_CORE1                       BUT(17)
> +#define EXYNOS5_USE_STANDBYWFI_ARM_CORE1                       BIT(17)
>  #define EXYNOS5_USE_STANDBYWFE_ARM_CORE0                       BIT(24)
>  #define EXYNOS5_USE_STANDBYWFE_ARM_CORE1                       BIT(25)
>
> --
> 2.27.0
>


-- 
Regards,
Alim