linux-kernel - Re: [PATCH v10 2/5] USB: misc: Add onboard_usb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210519144356.GB1165692@rowland.harvard.edu>
Date:   Wed, 19 May 2021 10:43:56 -0400
From:   Alan Stern <stern@...land.harvard.edu>
To:     Matthias Kaehlcke <mka@...omium.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Rob Herring <robh+dt@...nel.org>,
        Frank Rowand <frowand.list@...il.com>,
        Michal Simek <michal.simek@...inx.com>,
        devicetree@...r.kernel.org,
        Douglas Anderson <dianders@...omium.org>,
        linux-usb@...r.kernel.org, Peter Chen <peter.chen@...nel.org>,
        linux-kernel@...r.kernel.org, Stephen Boyd <swboyd@...omium.org>,
        Ravi Chandra Sadineni <ravisadineni@...omium.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Bastien Nocera <hadess@...ess.net>,
        Al Cooper <alcooperx@...il.com>,
        "Alexander A. Klimov" <grandmaster@...klimov.de>,
        Masahiro Yamada <masahiroy@...nel.org>
Subject: Re: [PATCH v10 2/5] USB: misc: Add onboard_usb_hub driver

On Tue, May 18, 2021 at 02:40:47PM -0700, Matthias Kaehlcke wrote:
> 
> Could you also have a look at "[4/5] usb: host: xhci-plat:
> Create platform device for onboard hubs in probe()"
> (https://lore.kernel.org/patchwork/patch/1425453/)? It's a
> relatively short patch that creates the platform device for
> the driver from xhci-plat as you suggested in the v4
> discussion.

I'm not the maintainer for xhci-related drivers.

However, there is at least one thing about this patch which looks 
suspicious: Adding the onboard_hub_dev pointer to struct usb_hcd instead 
of to struct xhci_plat_priv, where it would make a lot more sense.

It's also worth mentioning that this approach won't work at all when the 
onboard hub is not at the top level (its parent isn't the root hub), or 
when more than one onboard hubs are connected to the same root hub.

Alan Stern