linux-kernel - Re: [PATCH -next] opp: use list_del_init instead of list_del/INIT_LIST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210520040337.k47l2fxstfs2l2q3@vireshk-i7>
Date:   Thu, 20 May 2021 09:33:37 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     Yang Yingliang <yangyingliang@...wei.com>
Cc:     linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
        vireshk@...nel.org
Subject: Re: [PATCH -next] opp: use list_del_init instead of
 list_del/INIT_LIST_HEAD

On 18-05-21, 12:49, Yang Yingliang wrote:
> Using list_del_init() instead of list_del() + INIT_LIST_HEAD()
> to simpify the code.
> 
> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>
> ---
>  drivers/opp/of.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/opp/of.c b/drivers/opp/of.c
> index c582a9ca397b..aa75a1caf08a 100644
> --- a/drivers/opp/of.c
> +++ b/drivers/opp/of.c
> @@ -433,8 +433,7 @@ static void lazy_link_required_opp_table(struct opp_table *new_table)
>  
>  		/* All required opp-tables found, remove from lazy list */
>  		if (!lazy) {
> -			list_del(&opp_table->lazy);
> -			INIT_LIST_HEAD(&opp_table->lazy);
> +			list_del_init(&opp_table->lazy);
>  
>  			list_for_each_entry(opp, &opp_table->opp_list, node)
>  				_required_opps_available(opp, opp_table->required_opp_count);

Applied. Thanks.

-- 
viresh