linux-kernel - Re: [PATCH 1/3] rcu/nocb: Start moving nocb code to its own plugin file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210520045436.GG4441@paulmck-ThinkPad-P17-Gen-1>
Date:   Wed, 19 May 2021 21:54:36 -0700
From:   "Paul E. McKenney" <paulmck@...nel.org>
To:     Frederic Weisbecker <frederic@...nel.org>
Cc:     LKML <linux-kernel@...r.kernel.org>, rcu@...r.kernel.org
Subject: Re: [PATCH 1/3] rcu/nocb: Start moving nocb code to its own plugin
 file

On Thu, May 20, 2021 at 03:02:54AM +0200, Frederic Weisbecker wrote:
> On Wed, May 19, 2021 at 08:55:08AM -0700, Paul E. McKenney wrote:
> > On Wed, May 19, 2021 at 02:09:28AM +0200, Frederic Weisbecker wrote:
> > > tree_plugin.h is now gathering not only the (no)preempt-rcu specifics
> > > but also other features like NO_CB. As the latter has grown quite in
> > > complexity and volume, it's may be a good idea to start moving the
> > > related code to its own file so we don't need to browse thousand lines
> > > to find what we need.
> > > 
> > > Suggested-by: Paul E. McKenney <paulmck@...nel.org>
> > > Signed-off-by: Frederic Weisbecker <frederic@...nel.org>
> > 
> > Applied with the usual wordsmithing, thank you!
> > 
> > But for consistency with the other similar files included by
> > kernel/rcu/tree.c, should the name instead be kernel/rcu/tree_nocb.h?
> 
> Ah yes, I hesitated but tree_nocb.h is indeed more consistent. Can I let
> you do the rename?

Done!

> > Also, if Ingo and I are one the author list, shouldn't you be as well?  ;-)
> 
> Heh, alright feel free to add the following as a fixup :-)

And again, done.  Or will be at the next rebase, anyway.

							Thanx, Paul

> diff --git a/kernel/rcu/nocb.h b/kernel/rcu/nocb.h
> index a7783923833e..bf2690ca5d2b 100644
> --- a/kernel/rcu/nocb.h
> +++ b/kernel/rcu/nocb.h
> @@ -6,9 +6,11 @@
>   *
>   * Copyright Red Hat, 2009
>   * Copyright IBM Corporation, 2009
> + * Copyright SUSE, 2021
>   *
>   * Author: Ingo Molnar <mingo@...e.hu>
>   *	   Paul E. McKenney <paulmck@...ux.ibm.com>
> + *	   Frederic Weisbecker <frederic@...nel.org>
>   */
>  
>  #ifdef CONFIG_RCU_NOCB_CPU
> 
> 
> Or perhaps you prefer a separate patch?
> 
> Thanks!