linux-kernel - RE: [PATCH v34 4/4] scsi: ufs: Add HPB 2.0 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 20 May 2021 12:32:28 +0000
From:   Avri Altman <Avri.Altman@....com>
To:     "daejun7.park@...sung.com" <daejun7.park@...sung.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "asutoshd@...eaurora.org" <asutoshd@...eaurora.org>,
        "stanley.chu@...iatek.com" <stanley.chu@...iatek.com>,
        "cang@...eaurora.org" <cang@...eaurora.org>,
        "bvanassche@....org" <bvanassche@....org>,
        "huobean@...il.com" <huobean@...il.com>,
        ALIM AKHTAR <alim.akhtar@...sung.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        JinHwan Park <jh.i.park@...sung.com>,
        Javier Gonzalez <javier.gonz@...sung.com>,
        Sung-Jun Park <sungjun07.park@...sung.com>,
        Jinyoung CHOI <j-young.choi@...sung.com>,
        Dukhyun Kwon <d_hyun.kwon@...sung.com>,
        Keoseong Park <keosung.park@...sung.com>,
        Jaemyung Lee <jaemyung.lee@...sung.com>,
        Jieon Seol <jieon.seol@...sung.com>
Subject: RE: [PATCH v34 4/4] scsi: ufs: Add HPB 2.0 support

> +       /* for pre_req */
> +       hpb->pre_req_min_tr_len = hpb_dev_info->max_hpb_single_cmd + 1;
> +
> +       if (ufshpb_is_legacy(hba))
> +               hpb->pre_req_max_tr_len = HPB_LEGACY_CHUNK_HIGH;
> +       else
> +               hpb->pre_req_max_tr_len = max(HPB_MULTI_CHUNK_HIGH,
> +                                             hpb->pre_req_min_tr_len);
I think this should only be
else
        hpb->pre_req_max_tr_len = HPB_MULTI_CHUNK_HIGH;

where HPB_MULTI_CHUNK_HIGH should fit into a single byte,
regardless of bMAX_ DATA_SIZE_FOR_HPB_SINGLE_CMD,
which being an attribute (u32) can be significantly larger.

Thanks,
Avri