linux-kernel - [PATCH 13/16] char: agp: generic: Place braces around optimised out function in if()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20210520121347.3467794-14-lee.jones@linaro.org>
Date:   Thu, 20 May 2021 13:13:44 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     lee.jones@...aro.org
Cc:     linux-kernel@...r.kernel.org, David Airlie <airlied@...ux.ie>
Subject: [PATCH 13/16] char: agp: generic: Place braces around optimised out function in if()

Fixes the following W=1 kernel build warning(s):

 drivers/char/agp/generic.c: In function ‘agp_generic_destroy_page’:
 drivers/char/agp/generic.c:1265:28: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]

Cc: David Airlie <airlied@...ux.ie>
Signed-off-by: Lee Jones <lee.jones@...aro.org>
---
 drivers/char/agp/generic.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/char/agp/generic.c b/drivers/char/agp/generic.c
index 3ffbb1c80c5c7..37a07676da6ff 100644
--- a/drivers/char/agp/generic.c
+++ b/drivers/char/agp/generic.c
@@ -1261,8 +1261,9 @@ void agp_generic_destroy_page(struct page *page, int flags)
 	if (page == NULL)
 		return;
 
-	if (flags & AGP_PAGE_DESTROY_UNMAP)
+	if (flags & AGP_PAGE_DESTROY_UNMAP) {
 		unmap_page_from_agp(page);
+	}
 
 	if (flags & AGP_PAGE_DESTROY_FREE) {
 		put_page(page);
-- 
2.31.1