linux-kernel - Re: [PATCH 00/16] Rid W=1 warnings from Char

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a0VujuG8eU_CEVSvzbk4nAJz8fStedM5eMUrLAr9EJxDQ@mail.gmail.com>
Date:   Thu, 20 May 2021 14:56:36 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Bob Picco <robert.picco@...com>,
        Clemens Ladisch <clemens@...isch.de>,
        "C. Scott Ananian" <cananian@...mni.princeton.edu>,
        "cs.c" <support.linux@...ikey.com>,
        Dave Safford <safford@...son.ibm.com>,
        David Airlie <airlied@...ux.ie>,
        David Woodhouse <dwmw2@...radead.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Harald Welte <laforge@...monks.org>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Jarkko Sakkinen <jarkko@...nel.org>,
        "Jason A. Donenfeld" <Jason@...c4.com>,
        Jason Gunthorpe <jgg@...pe.ca>,
        Jerome Glisse <j.glisse@...il.com>,
        Kanoj Sarcar <kanoj@....com>, Kylene Hall <kjhall@...ibm.com>,
        Lijun Pan <ljp@...ux.ibm.com>,
        "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" 
        <linux-crypto@...r.kernel.org>, linux-integrity@...r.kernel.org,
        linuxppc-dev <linuxppc-dev@...ts.ozlabs.org>,
        Matt Mackall <mpm@...enic.com>,
        Michael Ellerman <mpe@...erman.id.au>,
        Michael Neuling <mikey@...ling.org>,
        Paul Fulghum <paulkf@...rogate.com>,
        Paul Mackerras <paulus@...ba.org>,
        Peter Huewe <peterhuewe@....de>,
        Reiner Sailer <sailer@...son.ibm.com>,
        "Theodore Ts'o" <tytso@....edu>,
        Thirupathaiah Annapureddy <thiruan@...rosoft.com>,
        Tyrel Datwyler <tyreld@...ux.ibm.com>,
        Uwe Kleine-König <uwe@...ine-koenig.org>,
        van Doorn <leendert@...son.ibm.com>
Subject: Re: [PATCH 00/16] Rid W=1 warnings from Char

On Thu, May 20, 2021 at 2:13 PM Lee Jones <lee.jones@...aro.org> wrote:
>
> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.
>
> Lee Jones (16):
>   char: pcmcia: cm4000_cs: Remove unused variable 'tmp'
>   char: pcmcia: cm4040_cs: Remove unused variable 'uc'
>   char: random: Include header containing our prototypes
>   char: pcmcia: synclink_cs: Fix a bunch of kernel-doc issues
>   char: pcmcia: synclink_cs: Fix a bunch of kernel-doc issues
>   char: applicom: Remove 3 unused variables 'ret' and 2 instances of
>     'byte_reset_it'
>   char: tpm: tpm1-cmd: Fix a couple of misnamed functions
>   char: tpm: tpm_ftpm_tee: Fix a couple of kernel-doc misdemeanours
>   char: agp: backend: Demote some non-conformant kernel-doc headers
>   char: agp: frontend: Include header file containing our prototypes
>   char: agp: via-agp: Remove unused variable 'current_size'
>   char: hpet: Remove unused variable 'm'
>   char: agp: generic: Place braces around optimised out function in if()
>   char: agp: uninorth-agp: Remove unused variable 'size'
>   char: hw_random: pseries-rng: Demote non-conformant kernel-doc header
>   char: mem: Provide local prototype for non-static function

Thanks a lot!

I've looked all the patches now and commented on patches 6 and 16.
With my comments addressed

Reviewed-by: Arnd Bergmann <arnd@...db.de>

       Arnd