linux-kernel - Re: [PATCH 2/6] comedi: drivers: jr3_pci: Remove set but unused variable 'min_full

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9d0ac108-7256-be1a-fdd9-f48f52aaa38e@mev.co.uk>
Date:   Thu, 20 May 2021 14:22:04 +0100
From:   Ian Abbott <abbotti@....co.uk>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     linux-kernel@...r.kernel.org,
        H Hartley Sweeten <hsweeten@...ionengravers.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Alexander A. Klimov" <grandmaster@...klimov.de>,
        Anders Blomdell <anders.blomdell@...trol.lth.se>,
        linux-staging@...ts.linux.dev
Subject: Re: [PATCH 2/6] comedi: drivers: jr3_pci: Remove set but unused
 variable 'min_full_scale'

On 20/05/2021 13:25, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
> 
>   drivers/staging/comedi/drivers/jr3_pci.c: In function ‘jr3_pci_poll_subdevice’:
>   drivers/staging/comedi/drivers/jr3_pci.c:507:22: warning: variable ‘min_full_scale’ set but not used [-Wunused-but-set-variable]
> 
> Cc: Ian Abbott <abbotti@....co.uk>
> Cc: H Hartley Sweeten <hsweeten@...ionengravers.com>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: "Alexander A. Klimov" <grandmaster@...klimov.de>
> Cc: Anders Blomdell <anders.blomdell@...trol.lth.se>
> Cc: linux-staging@...ts.linux.dev
> Signed-off-by: Lee Jones <lee.jones@...aro.org>
> ---
>   drivers/comedi/drivers/jr3_pci.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)

Actually, that one is stale now (or will be when Greg's staging-next 
branch gets merged into linux-next soon):

https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/commit/?h=staging-next&id=b9f38e913a926b455e5048a95f53a993b515509f

| staging: comedi: Remove unused variable ‘min_full_scale’ and function 
'get_min_full_scales'
|
| The variable ‘min_full_scale’ and function 'get_min_full_scales' are
| not used, So delete them.

-- 
-=( Ian Abbott <abbotti@....co.uk> || MEV Ltd. is a company  )=-
-=( registered in England & Wales.  Regd. number: 02862268.  )=-
-=( Regd. addr.: S11 & 12 Building 67, Europa Business Park, )=-
-=( Bird Hall Lane, STOCKPORT, SK3 0XA, UK. || www.mev.co.uk )=-