linux-kernel - Re: [PATCH] tools/bootconfig: Fix a build error accroding to undefined fallthrough

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 20 May 2021 23:07:38 +0900
From:   Masami Hiramatsu <mhiramat@...nel.org>
To:     Masami Hiramatsu <mhiramat@...nel.org>
Cc:     Steven Rostedt <rostedt@...dmis.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>
Subject: Re: [PATCH] tools/bootconfig: Fix a build error accroding to
 undefined fallthrough

Hi Steve,

Can you pick at least this fix since it is a critical bug?

Thank you,

On Thu, 13 May 2021 12:06:33 +0900
Masami Hiramatsu <mhiramat@...nel.org> wrote:

> Since the "fallthrough" is defined only in the kernel, building
> lib/bootconfig.c as a part of user-space tools causes a build
> error.
> 
> Add a dummy fallthrough to avoid the build error.
> 
> Cc: stable@...r.kernel.org
> Fixes: 4c1ca831adb1 ("Revert "lib: Revert use of fallthrough pseudo-keyword in lib/"")
> Signed-off-by: Masami Hiramatsu <mhiramat@...nel.org>
> ---
>  tools/bootconfig/include/linux/bootconfig.h |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/tools/bootconfig/include/linux/bootconfig.h b/tools/bootconfig/include/linux/bootconfig.h
> index 078cbd2ba651..de7f30f99af3 100644
> --- a/tools/bootconfig/include/linux/bootconfig.h
> +++ b/tools/bootconfig/include/linux/bootconfig.h
> @@ -4,4 +4,8 @@
>  
>  #include "../../../../include/linux/bootconfig.h"
>  
> +#ifndef fallthrough
> +# define fallthrough
> +#endif
> +
>  #endif
> 


-- 
Masami Hiramatsu <mhiramat@...nel.org>