linux-kernel - Re: [PATCH] module: correctly exit module_kallsyms_on_each

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <alpine.LSU.2.21.2105201639330.1498@pobox.suse.cz>
Date:   Thu, 20 May 2021 16:39:43 +0200 (CEST)
From:   Miroslav Benes <mbenes@...e.cz>
To:     Jon Mediero <jmdr@...root.org>
cc:     Jessica Yu <jeyu@...nel.org>, Petr Mladek <pmladek@...e.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] module: correctly exit module_kallsyms_on_each_symbol
 when fn() != 0

On Thu, 20 May 2021, Jon Mediero wrote:

> Commit 013c1667cf78 ("kallsyms: refactor
> {,module_}kallsyms_on_each_symbol") replaced the return inside the
> nested loop with a break, changing the semantics of the function: the
> break only exits the innermost loop, so the code continues iterating the
> symbols of the next module instead of exiting.
> 
> Fixes: 013c1667cf78 ("kallsyms: refactor {,module_}kallsyms_on_each_symbol")
> Signed-off-by: Jon Mediero <jmdr@...root.org>

Reviewed-by: Miroslav Benes <mbenes@...e.cz>

M