linux-kernel - Re: [PATCH 1/6] dt-bindings: mfd: ti,j721e-system-controller: Fix mux node errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 20 May 2021 20:11:58 +0530
From:   Kishon Vijay Abraham I <kishon@...com>
To:     Rob Herring <robh@...nel.org>, <devicetree@...r.kernel.org>,
        Peter Rosin <peda@...ntia.se>, Wolfram Sang <wsa@...nel.org>
CC:     <linux-kernel@...r.kernel.org>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Jacopo Mondi <jacopo+renesas@...ndi.org>,
        Kieran Bingham <kieran.bingham+renesas@...asonboard.com>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Lee Jones <lee.jones@...aro.org>,
        Niklas Söderlund 
        <niklas.soderlund+renesas@...natech.se>,
        Jonathan Cameron <jic23@...nel.org>
Subject: Re: [PATCH 1/6] dt-bindings: mfd: ti,j721e-system-controller: Fix mux
 node errors

Hi Rob,

On 19/05/21 4:58 am, Rob Herring wrote:
> The ti,j721e-system-controller binding does not follow the standard mux
> controller node name 'mux-controller' and the example is incomplete. Fix
> these to avoid schema errors before the mux controller binding is
> converted to schema.
> 
> Cc: Lee Jones <lee.jones@...aro.org>
> Cc: Kishon Vijay Abraham I <kishon@...com>
> Cc: Roger Quadros <rogerq@...com>
> Signed-off-by: Rob Herring <robh@...nel.org>
> ---
>  .../mfd/ti,j721e-system-controller.yaml       | 19 +++++++++++++------
>  1 file changed, 13 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml
> index 19fcf59fd2fe..272832e9f8f2 100644
> --- a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml
> +++ b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml
> @@ -43,12 +43,10 @@ properties:
>  
>  patternProperties:
>    # Optional children
> -  "^serdes-ln-ctrl@[0-9a-f]+$":
> +  "^mux-controller@[0-9a-f]+$":
>      type: object
> -    description: |
> -      This is the SERDES lane control mux. It should follow the bindings
> -      specified in
> -      Documentation/devicetree/bindings/mux/reg-mux.txt
> +    description:
> +      This is the SERDES lane control mux.
>  
>  required:
>    - compatible
> @@ -68,9 +66,18 @@ examples:
>          #size-cells = <1>;
>          ranges;
>  
> -        serdes_ln_ctrl: serdes-ln-ctrl@...0 {
> +        serdes_ln_ctrl: mux-controller@...0 {
>              compatible = "mmio-mux";
>              reg = <0x00004080 0x50>;

"mmio-mux" compatible doesn't define using "reg" property. But a system
can have multiple mux-controllers which would require us to use
mux-controller@0, mux-controller@1,..

And IIRC if we have "@", 'reg' will be a required required property.
Would it be an issue here?

Thanks
Kishon