linux-kernel - Re: [PATCH v1 1/1] infiniband: hf1: Use string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210520152735.GA2742506@nvidia.com>
Date:   Thu, 20 May 2021 12:27:35 -0300
From:   Jason Gunthorpe <jgg@...dia.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org,
        Mike Marciniszyn <mike.marciniszyn@...nelisnetworks.com>,
        Dennis Dalessandro <dennis.dalessandro@...nelisnetworks.com>,
        Doug Ledford <dledford@...hat.com>
Subject: Re: [PATCH v1 1/1] infiniband: hf1: Use string_upper() instead of
 open coded variant

On Tue, May 18, 2021 at 03:41:11PM +0300, Andy Shevchenko wrote:
> Use string_upper() from string helper module instead of open coded variant.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  drivers/infiniband/hw/hfi1/efivar.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)

It doesn't compile??

In file included from drivers/infiniband/hw/hfi1/efivar.c:48:
./include/linux/string_helpers.h: In function ‘string_escape_str’:
./include/linux/string_helpers.h:70:32: error: implicit declaration of function ‘strlen’ [-Werror=implicit-function-declaration]
   70 |  return string_escape_mem(src, strlen(src), dst, sz, flags, only);
      |                                ^~~~~~
./include/linux/string_helpers.h:70:32: warning: incompatible implicit declaration of built-in function ‘strlen’
./include/linux/string_helpers.h:6:1: note: include ‘<string.h>’ or provide a declaration of ‘strlen’
    5 | #include <linux/ctype.h>
  +++ |+#include <string.h>
    6 | #include <linux/types.h>
cc1: some warnings being treated as errors

Jason