linux-kernel - Re: [PATCH 2/2] mtd: partitions: redboot: fix style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdZhhNQupN_4Oh759bKL7sEM9M=yOW1y-mT69ugEkjRMZw@mail.gmail.com>
Date:   Thu, 20 May 2021 18:00:04 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Miquel Raynal <miquel.raynal@...tlin.com>
Cc:     Corentin Labbe <clabbe@...libre.com>,
        Boris Brezillon <boris.brezillon@...tlin.com>,
        Richard Weinberger <richard@....at>,
        Vignesh R <vigneshr@...com>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        linux-mtd@...ts.infradead.org
Subject: Re: [PATCH 2/2] mtd: partitions: redboot: fix style issues

On Thu, May 20, 2021 at 5:36 PM Miquel Raynal <miquel.raynal@...tlin.com> wrote:
> Linus Walleij <linus.walleij@...aro.org> wrote on Thu, 20 May 2021
> 17:24:26 +0200:
> > On Thu, May 20, 2021 at 1:49 PM Corentin Labbe <clabbe@...libre.com> wrote:
> >
> > > This patch fixes easy checkpatch issues.
> > >
> > > Signed-off-by: Corentin Labbe <clabbe@...libre.com>
> > (...)
> > > -    uint32_t     flash_base;    // Address within FLASH of image
> > (...)
> > > +       u32       flash_base;    // Address within FLASH of image
> >
> > Does checkpatch complain about this? At one point the MTD maintainer
> > disliked the u32/u16/u8 types and explicitly wanted to use the C
> > standard library types, and it's the kind of eccentric maintainer
> > deviations we accommodate for.
>
> I suppose this happened quite some time ago? :)
>
> I've never heard Richard nor Boris complaining about it, nor will I.

Yes that was a specific David Woodhouse preference.
I'm too old!

Yours,
Linus Walleij