linux-kernel - Re: [PATCH 08/16] char: tpm: tpm_ftpm_tee: Fix a couple of kernel-doc misdemeanours

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YKaRpdpxTVr8Igm1@kernel.org>
Date:   Thu, 20 May 2021 19:43:17 +0300
From:   Jarkko Sakkinen <jarkko@...nel.org>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     linux-kernel@...r.kernel.org, Peter Huewe <peterhuewe@....de>,
        Jason Gunthorpe <jgg@...pe.ca>,
        Thirupathaiah Annapureddy <thiruan@...rosoft.com>,
        linux-integrity@...r.kernel.org
Subject: Re: [PATCH 08/16] char: tpm: tpm_ftpm_tee: Fix a couple of
 kernel-doc misdemeanours

On Thu, May 20, 2021 at 01:13:39PM +0100, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/char/tpm/tpm_ftpm_tee.c:218: warning: Function parameter or member 'dev' not described in 'ftpm_tee_probe'
>  drivers/char/tpm/tpm_ftpm_tee.c:218: warning: Excess function parameter 'pdev' description in 'ftpm_tee_probe'
>  drivers/char/tpm/tpm_ftpm_tee.c:314: warning: Function parameter or member 'dev' not described in 'ftpm_tee_remove'
>  drivers/char/tpm/tpm_ftpm_tee.c:314: warning: Excess function parameter 'pdev' description in 'ftpm_tee_remove'
>  drivers/char/tpm/tpm_ftpm_tee.c:349: warning: expecting prototype for ftpm_tee_shutdown(). Prototype was for ftpm_plat_tee_shutdown() instead
> 
> Cc: Peter Huewe <peterhuewe@....de>
> Cc: Jarkko Sakkinen <jarkko@...nel.org>
> Cc: Jason Gunthorpe <jgg@...pe.ca>
> Cc: Thirupathaiah Annapureddy <thiruan@...rosoft.com>
> Cc: linux-integrity@...r.kernel.org
> Signed-off-by: Lee Jones <lee.jones@...aro.org>


Reviewed-by: Jarkko Sakkinen <jarkko@...nel.org>

/Jarkko

> ---
>  drivers/char/tpm/tpm_ftpm_tee.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/char/tpm/tpm_ftpm_tee.c b/drivers/char/tpm/tpm_ftpm_tee.c
> index 2ccdf8ac69948..2d9c0ecd43f0a 100644
> --- a/drivers/char/tpm/tpm_ftpm_tee.c
> +++ b/drivers/char/tpm/tpm_ftpm_tee.c
> @@ -209,7 +209,7 @@ static int ftpm_tee_match(struct tee_ioctl_version_data *ver, const void *data)
>  
>  /**
>   * ftpm_tee_probe() - initialize the fTPM
> - * @pdev: the platform_device description.
> + * @dev: the platform_device description.
>   *
>   * Return:
>   *	On success, 0. On failure, -errno.
> @@ -305,7 +305,7 @@ static int ftpm_plat_tee_probe(struct platform_device *pdev)
>  
>  /**
>   * ftpm_tee_remove() - remove the TPM device
> - * @pdev: the platform_device description.
> + * @dev: the platform_device description.
>   *
>   * Return:
>   *	0 always.
> @@ -342,7 +342,7 @@ static int ftpm_plat_tee_remove(struct platform_device *pdev)
>  }
>  
>  /**
> - * ftpm_tee_shutdown() - shutdown the TPM device
> + * ftpm_plat_tee_shutdown() - shutdown the TPM device
>   * @pdev: the platform_device description.
>   */
>  static void ftpm_plat_tee_shutdown(struct platform_device *pdev)
> -- 
> 2.31.1
> 
>