linux-kernel - Re: [PATCH] staging: iio: fix some formatting issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 20 May 2021 14:13:56 -0300
From:   Marcelo Schmitt <marcelo.schmitt1@...il.com>
To:     Wang Qing <wangqing@...o.com>
Cc:     Lars-Peter Clausen <lars@...afoo.de>,
        Michael Hennerich <Michael.Hennerich@...log.com>,
        Jonathan Cameron <jic23@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-iio@...r.kernel.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: iio: fix some formatting issues

Hi Wang,

Nice patch for a start. Yet, I think there is room for some improvement.

On 05/19, Wang Qing wrote:
> fixing:
If you wish, you may add here that this style check is reported by
checkpatch.

> CHECK: Alignment should match open parenthesis
> #1351: FILE: drivers/staging/iio/addac/adt7316.c:1351:
Checkpatch warns that commit log lines starting with '#' are dropped by
git as comments. Is this intentional?

> 
> CHECK: Alignment should match open parenthesis
> #1378: FILE: drivers/staging/iio/addac/adt7316.c:1378:
Same warning here.

Its probably not a requirement, but the subject line could be more
specific about where the changes are for. Maybe start with
staging: iio: addac:
or even
staging: iio: addac: adt7316:


Regards,

Marcelo

> 
> Signed-off-by: Wang Qing <wangqing@...o.com>
> ---
>  drivers/staging/iio/addac/adt7316.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c
> index ccbafca..79467f0 100644
> --- a/drivers/staging/iio/addac/adt7316.c
> +++ b/drivers/staging/iio/addac/adt7316.c
> @@ -1348,9 +1348,9 @@ static ssize_t adt7316_show_in_analog_temp_offset(struct device *dev,
>  }
>  
>  static ssize_t adt7316_store_in_analog_temp_offset(struct device *dev,
> -						struct device_attribute *attr,
> -						const char *buf,
> -						size_t len)
> +						   struct device_attribute *attr,
> +						   const char *buf,
> +						   size_t len)
>  {
>  	struct iio_dev *dev_info = dev_to_iio_dev(dev);
>  	struct adt7316_chip_info *chip = iio_priv(dev_info);
> @@ -1375,9 +1375,9 @@ static ssize_t adt7316_show_ex_analog_temp_offset(struct device *dev,
>  }
>  
>  static ssize_t adt7316_store_ex_analog_temp_offset(struct device *dev,
> -						struct device_attribute *attr,
> -						const char *buf,
> -						size_t len)
> +						   struct device_attribute *attr,
> +						   const char *buf,
> +						   size_t len)
>  {
>  	struct iio_dev *dev_info = dev_to_iio_dev(dev);
>  	struct adt7316_chip_info *chip = iio_priv(dev_info);
> -- 
> 2.7.4
>