linux-kernel - Re: [PATCH] staging: emxx_udc: Fixed coding style in places where lines should not end in '('

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 20 May 2021 20:00:45 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Hriday Hegde <hridayhegde1999@...il.com>
Cc:     Alex Dewar <alex.dewar90@...il.com>,
        Sean Behan <codebam@...eup.net>,
        Colin Ian King <colin.king@...onical.com>,
        Kumar Kartikeya Dwivedi <memxor@...il.com>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: emxx_udc: Fixed coding style in places where
 lines should not end in '('

On Thu, May 20, 2021 at 10:46:57AM -0700, Hriday Hegde wrote:
> The fixes were for the following checkpatch outputs:
> 
> CHECK: Lines should not end with a '('
> 1076: FILE: drivers/staging/emxx_udc/emxx_udc.c:1076:
> +				_nbu2ss_writel(
> 
> CHECK: Lines should not end with a '('
> 1228: FILE: drivers/staging/emxx_udc/emxx_udc.c:1228:
> +		length = _nbu2ss_readl(
> 
> CHECK: Lines should not end with a '('
> 1465: FILE: drivers/staging/emxx_udc/emxx_udc.c:1465:
> +			regdata = _nbu2ss_readl(
> 
> Signed-off-by: Hriday Hegde <hridayhegde1999@...il.com>
> ---
>  drivers/staging/emxx_udc/emxx_udc.c | 10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c
> index 741147a4f0fe..8364316c1d25 100644
> --- a/drivers/staging/emxx_udc/emxx_udc.c
> +++ b/drivers/staging/emxx_udc/emxx_udc.c
> @@ -1073,8 +1073,8 @@ static int _nbu2ss_epn_in_pio(struct nbu2ss_udc *udc, struct nbu2ss_ep *ep,
>  		i_word_length = length / sizeof(u32);
>  		if (i_word_length > 0) {
>  			for (i = 0; i < i_word_length; i++) {
> -				_nbu2ss_writel(
> -					&preg->EP_REGS[ep->epnum - 1].EP_WRITE,
> +				_nbu2ss_writel(&preg->EP_REGS[ep->epnum - 1]
> +					.EP_WRITE,

Please don't break the line at ".", that makes this really hard to
follow.

thanks,

greg k-h