linux-kernel - Re: [PATCH 20/38] drm/radeon/radeon_vm: Fix function naming disparities

Open Source and information security mailing list archives

Date:   Thu, 20 May 2021 15:16:53 -0400
From:   Alex Deucher <alexdeucher@...il.com>
To:     Christian König <christian.koenig@....com>
Cc:     Lee Jones <lee.jones@...aro.org>, David Airlie <airlied@...ux.ie>,
        LKML <linux-kernel@...r.kernel.org>,
        Maling list - DRI developers 
        <dri-devel@...ts.freedesktop.org>,
        amd-gfx list <amd-gfx@...ts.freedesktop.org>,
        Daniel Vetter <daniel@...ll.ch>,
        Alex Deucher <alexander.deucher@....com>
Subject: Re: [PATCH 20/38] drm/radeon/radeon_vm: Fix function naming disparities

Applied.  Thanks!

On Thu, May 20, 2021 at 8:05 AM Christian König
<christian.koenig@....com> wrote:
>
> Am 20.05.21 um 14:02 schrieb Lee Jones:
> > Fixes the following W=1 kernel build warning(s):
> >
> >   drivers/gpu/drm/radeon/radeon_vm.c:61: warning: expecting prototype for radeon_vm_num_pde(). Prototype was for radeon_vm_num_pdes() instead
> >   drivers/gpu/drm/radeon/radeon_vm.c:642: warning: expecting prototype for radeon_vm_update_pdes(). Prototype was for radeon_vm_update_page_directory() instead
> >
> > Cc: Alex Deucher <alexander.deucher@....com>
> > Cc: "Christian König" <christian.koenig@....com>
> > Cc: David Airlie <airlied@...ux.ie>
> > Cc: Daniel Vetter <daniel@...ll.ch>
> > Cc: amd-gfx@...ts.freedesktop.org
> > Cc: dri-devel@...ts.freedesktop.org
> > Signed-off-by: Lee Jones <lee.jones@...aro.org>
>
> Reviewed-by: Christian König <christian.koenig@....com>
>
> > ---
> >   drivers/gpu/drm/radeon/radeon_vm.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/radeon/radeon_vm.c b/drivers/gpu/drm/radeon/radeon_vm.c
> > index 2dc9c9f98049b..36a38adaaea96 100644
> > --- a/drivers/gpu/drm/radeon/radeon_vm.c
> > +++ b/drivers/gpu/drm/radeon/radeon_vm.c
> > @@ -51,7 +51,7 @@
> >    */
> >
> >   /**
> > - * radeon_vm_num_pde - return the number of page directory entries
> > + * radeon_vm_num_pdes - return the number of page directory entries
> >    *
> >    * @rdev: radeon_device pointer
> >    *
> > @@ -626,7 +626,7 @@ static uint32_t radeon_vm_page_flags(uint32_t flags)
> >   }
> >
> >   /**
> > - * radeon_vm_update_pdes - make sure that page directory is valid
> > + * radeon_vm_update_page_directory - make sure that page directory is valid
> >    *
> >    * @rdev: radeon_device pointer
> >    * @vm: requested vm
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives