linux-kernel - Re: [PATCH] linux/bits.h: Fix compilation error with GENMASK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a1i1XE_rUrg_kX87NPA7NBJa5m2gVrHSuBE3XzFLUKPWA@mail.gmail.com>
Date:   Thu, 20 May 2021 22:15:02 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Yury Norov <yury.norov@...il.com>
Cc:     Rikard Falkeborn <rikard.falkeborn@...il.com>,
        Ard Biesheuvel <ardb@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH] linux/bits.h: Fix compilation error with GENMASK

On Thu, May 20, 2021 at 9:44 PM Yury Norov <yury.norov@...il.com> wrote:
> On Thu, May 20, 2021 at 08:46:40PM +0200, Rikard Falkeborn wrote:
> > > > +/*
> > > > + * This returns a constant expression while determining if an argument is
> > > > + * a constant expression, most importantly without evaluating the argument.
> > > > + * Glory to Martin Uecker <Martin.Uecker@....uni-goettingen.de>
> > > > + */
> > > > +#define __is_constexpr(x) \
> > > > +       (sizeof(int) == sizeof(*(8 ? ((void *)((long)(x) * 0l)) : (int *)8)))
> > > > +
> > > >  #endif /* _LINUX_CONST_H */
> > > > --
> > > > 2.31.1
> > > >
> >
> > Friendly ping.
>
> I added this patch in my Bitmap tree, but since it's actually a build
> bug fix, I think it's worth to move it faster with Arnd's or Andrew's
> trees?

I have a few days off next week and won't be able to validate it before then,
so it would be faster to have Andrew pick it up.

Moving the definition to const.h seem reasonable to me here, feel
free to add

Acked-by: Arnd Bergmann <arnd@...db.de>