linux-kernel - Re: [RFC v2 27/32] x86/tdx: Exclude Shared bit from __PHYSICAL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f348c391-c665-2987-898c-718d2c53729f@linux.intel.com>
Date:   Thu, 20 May 2021 13:31:11 -0700
From:   Andi Kleen <ak@...ux.intel.com>
To:     Sean Christopherson <seanjc@...gle.com>,
        "Kuppuswamy, Sathyanarayanan" 
        <sathyanarayanan.kuppuswamy@...ux.intel.com>
Cc:     Dave Hansen <dave.hansen@...el.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Andy Lutomirski <luto@...nel.org>,
        Dan Williams <dan.j.williams@...el.com>,
        Tony Luck <tony.luck@...el.com>,
        Kirill Shutemov <kirill.shutemov@...ux.intel.com>,
        Kuppuswamy Sathyanarayanan <knsathya@...nel.org>,
        Raj Ashok <ashok.raj@...el.com>, linux-kernel@...r.kernel.org
Subject: Re: [RFC v2 27/32] x86/tdx: Exclude Shared bit from __PHYSICAL_MASK


On 5/20/2021 1:16 PM, Sean Christopherson wrote:
> On Thu, May 20, 2021, Kuppuswamy, Sathyanarayanan wrote:
>> So what is your proposal? "tdx_guest_" / "tdx_host_" ?
>    1. Abstract things where appropriate, e.g. I'm guessing there is a clever way
>       to deal with the shared vs. private inversion and avoid tdg_shared_mask
>       altogether.
>
>    2. Steal what SEV-ES did for the #VC handlers and use ve_ as the prefix for
>       handlers.
>
>    3. Use tdx_ everywhere else and handle the conflicts on a case-by-case basis
>       with a healthy dose of common sense.  E.g. there should be no need to worry
>       about "static __cpuidle void tdg_safe_halt(void)" colliding because neither
>       the guest nor KVM should be exposing tdx_safe_halt() outside of its
>       compilation unit.


Sorry Sean, but your suggestion is against all good code hygiene 
practices. Normally we try to pick unique prefixes for every module, and 
trying to coordinate with lots of other code that is maintained by other 
people is just a long term recipe for annoying merging problems.  Same 
with coordinating with SEV-ES for ve_.

Is it really that hard to adjust your grep patterns?

I'm not against changing tdg_, but if it's changed it should be 
something unique, and also not too long. Today tdg_ fits that criteria 
nicely.


-Andi