linux-kernel - Re: [PATCH -next] erofs: fix error return code in erofs_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210520084023.GA5720@hsiangkao-HP-ZHAN-66-Pro-G1>
Date:   Thu, 20 May 2021 16:40:24 +0800
From:   Gao Xiang <xiang@...nel.org>
To:     Dan Carpenter <dan.carpenter@...cle.com>,
        Wei Yongjun <weiyongjun1@...wei.com>
Cc:     Pratik Shinde <pratikshinde320@...il.com>,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
        Hulk Robot <hulkci@...wei.com>, Gao Xiang <xiang@...nel.org>,
        linux-erofs@...ts.ozlabs.org
Subject: Re: [PATCH -next] erofs: fix error return code in
 erofs_read_superblock()

Hi Yongjun and Dan,

On Thu, May 20, 2021 at 08:32:26AM +0300, Dan Carpenter wrote:
> On Wed, May 19, 2021 at 02:16:57PM +0000, Wei Yongjun wrote:
> > 'ret' will be overwritten to 0 if erofs_sb_has_sb_chksum() return true,
> > thus 0 will return in some error handling cases. Fix to return negative
> > error code -EINVAL instead of 0.
> > 
> > Reported-by: Hulk Robot <hulkci@...wei.com>
> > Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
> 
> You need to add Fixes tags to bug fix patches and you need to ensure
> that the authors of the Fixes commit are CC'd so they can review your
> fix.  get_maintainer.pl will add the author automatically, but normally
> I like to put them in the To header to make sure they see it.
> 
> Fixes: b858a4844cfb ("erofs: support superblock checksum")

The commit and the tag look good to me (sorry for a bit delay on this),

Fixes: b858a4844cfb ("erofs: support superblock checksum")
Cc: stable <stable@...r.kernel.org> # 5.5+
Reviewed-by: Gao Xiang <xiang@...nel.org>

(will apply to dev-test for a while and then to -next.)

Thanks,
Gao Xiang