linux-kernel - Re: [PATCH 3/4] ARM: change vmalloc_min to vmalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210520090024.GB30436@shell.armlinux.org.uk>
Date:   Thu, 20 May 2021 10:00:24 +0100
From:   "Russell King (Oracle)" <linux@...linux.org.uk>
To:     "Xu, Yanfei" <yanfei.xu@...driver.com>
Cc:     rppt@...nel.org, ardb@...nel.org, linus.walleij@...aro.org,
        akpm@...ux-foundation.org, carver4lio@....com,
        tiantao6@...ilicon.com, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] ARM: change vmalloc_min to vmalloc_start

On Wed, May 19, 2021 at 12:41:10PM +0800, Xu, Yanfei wrote:
> On 5/18/21 8:15 PM, Russell King (Oracle) wrote:
> > -static unsigned long __initdata vmalloc_min =
> > -       VMALLOC_END - (240 << 20) - VMALLOC_OFFSET;
> > +static unsigned long __initdata vmalloc_start = VMALLOC_END - (240 << 20);
> > 
> >   /*
> >    * vmalloc=size forces the vmalloc area to be exactly 'size'
> > @@ -1169,7 +1168,8 @@ void __init adjust_lowmem_bounds(void)
> >           * and may itself be outside the valid range for which phys_addr_t
> >           * and therefore __pa() is defined.
> >           */
> > -       vmalloc_limit = (u64)vmalloc_min - PAGE_OFFSET + PHYS_OFFSET;
> > +       vmalloc_limit = (u64)vmalloc_start -
> > +                       (PAGE_OFFSET + PHYS_OFFSET + VMALLOC_OFFSET);
> > 
> Here is bug, it should be
> 
>        vmalloc_limit = (u64)vmalloc_start -
>                        (PAGE_OFFSET + VMALLOC_OFFSET) + PHYS_OFFSET;

Yes, you're absolutely right, thanks for catching that!

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!