linux-kernel - Re: [PATCH] ACPI: APEI: Don't warn if ACPI is disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 21 May 2021 19:01:40 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Jon Hunter <jonathanh@...dia.com>
Cc:     "Rafael J . Wysocki" <rjw@...ysocki.net>,
        Len Brown <lenb@...nel.org>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-tegra <linux-tegra@...r.kernel.org>
Subject: Re: [PATCH] ACPI: APEI: Don't warn if ACPI is disabled

On Fri, May 14, 2021 at 5:34 PM Jon Hunter <jonathanh@...dia.com> wrote:
>
> If ACPI is not enabled but support for ACPI and APEI is enabled in the
> kernel, then the following warning is seen on boot ...
>
>  WARNING KERN EINJ: ACPI disabled.
>
> For ARM64 platforms, the 'acpi_disabled' variable is true by default
> and hence, the above is often seen on ARM64. Given that it can be
> normal for ACPI to be disabled, make this an informational print rather
> that a warning.
>
> Signed-off-by: Jon Hunter <jonathanh@...dia.com>
> ---
> Please note that the motivation for this change is to filter out
> any warnings that might not be actual issues. We have some automated
> tests that we run to catch warnings and errors and although we could
> add this to a list of non critical warnings, it is preferred to make
> this an informational print.
>
>  drivers/acpi/apei/einj.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/apei/einj.c b/drivers/acpi/apei/einj.c
> index 328e8aeece6c..2882450c443e 100644
> --- a/drivers/acpi/apei/einj.c
> +++ b/drivers/acpi/apei/einj.c
> @@ -673,7 +673,7 @@ static int __init einj_init(void)
>         struct apei_exec_context ctx;
>
>         if (acpi_disabled) {
> -               pr_warn("ACPI disabled.\n");
> +               pr_info("ACPI disabled.\n");
>                 return -ENODEV;
>         }
>
> --

Applied as 5.14 material, thanks!