linux-kernel - Re: [PATCH][RESEND] zram: move backing_dev under macro CONFIG_ZRAM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YKfxgGe6evFf7dr+@google.com>
Date:   Fri, 21 May 2021 10:44:32 -0700
From:   Minchan Kim <minchan@...nel.org>
To:     Yue Hu <zbestahu@...il.com>, akpm@...ux-foundation.org
Cc:     ngupta@...are.org, senozhatsky@...omium.org, axboe@...nel.dk,
        linux-kernel@...r.kernel.org, linux-block@...r.kernel.org,
        huyue2@...ong.com, zbestahu@....com,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>
Subject: Re: [PATCH][RESEND] zram: move backing_dev under macro
 CONFIG_ZRAM_WRITEBACK

On Fri, May 21, 2021 at 02:05:44PM +0800, Yue Hu wrote:
> From: Yue Hu <huyue2@...ong.com>
> 
> backing_dev is never used when not enable CONFIG_ZRAM_WRITEBACK and
> it's introduced from writeback feature. So it's needless also affect
> readability in that case.
> 
> Signed-off-by: Yue Hu <huyue2@...ong.com>
> Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@...il.com>
> Acked-by: Minchan Kim <minchan@...nel.org>

Andrew, could you pick?

> ---
>  drivers/block/zram/zram_drv.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/block/zram/zram_drv.h b/drivers/block/zram/zram_drv.h
> index 419a7e8..6e73dc3 100644
> --- a/drivers/block/zram/zram_drv.h
> +++ b/drivers/block/zram/zram_drv.h
> @@ -113,8 +113,8 @@ struct zram {
>  	 * zram is claimed so open request will be failed
>  	 */
>  	bool claim; /* Protected by bdev->bd_mutex */
> -	struct file *backing_dev;
>  #ifdef CONFIG_ZRAM_WRITEBACK
> +	struct file *backing_dev;
>  	spinlock_t wb_limit_lock;
>  	bool wb_limit_enable;
>  	u64 bd_wb_limit;
> -- 
> 1.9.1
>