linux-kernel - Re: [PATCH v2] b43: don't save dentries for debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YKf/m0DO66rPA0jb@kroah.com>
Date:   Fri, 21 May 2021 20:44:43 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Kalle Valo <kvalo@...eaurora.org>
Cc:     linux-wireless@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Kees Cook <keescook@...omium.org>,
        Jason Gunthorpe <jgg@...pe.ca>, Chao Yu <chao@...nel.org>,
        Leon Romanovsky <leon@...nel.org>, b43-dev@...ts.infradead.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] b43: don't save dentries for debugfs

On Tue, May 18, 2021 at 08:47:58PM +0300, Kalle Valo wrote:
> Greg Kroah-Hartman <gregkh@...uxfoundation.org> writes:
> 
> > There is no need to keep around the dentry pointers for the debugfs
> > files as they will all be automatically removed when the subdir is
> > removed.  So save the space and logic involved in keeping them around by
> > just getting rid of them entirely.
> >
> > By doing this change, we remove one of the last in-kernel user that was
> > storing the result of debugfs_create_bool(), so that api can be cleaned
> > up.
> >
> > Cc: Kalle Valo <kvalo@...eaurora.org>
> > Cc: "David S. Miller" <davem@...emloft.net>
> > Cc: Jakub Kicinski <kuba@...nel.org>
> > Cc: Kees Cook <keescook@...omium.org>
> > Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > Cc: Jason Gunthorpe <jgg@...pe.ca>
> > Cc: Chao Yu <chao@...nel.org>
> > Cc: Leon Romanovsky <leon@...nel.org>
> > Cc: linux-wireless@...r.kernel.org
> > Cc: b43-dev@...ts.infradead.org
> > Cc: netdev@...r.kernel.org
> > Cc: linux-kernel@...r.kernel.org
> > Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > ---
> >  drivers/net/wireless/broadcom/b43/debugfs.c | 34 +++------------------
> >  drivers/net/wireless/broadcom/b43/debugfs.h |  3 --
> >  2 files changed, 5 insertions(+), 32 deletions(-)
> >
> > Note, I can take this through my debugfs tree if wanted, that way I can
> > clean up the debugfs_create_bool() api at the same time.  Otherwise it's
> > fine, I can wait until next -rc1 for that to happen.
> 
> Yeah, it's best that you take this via your tree.
> 
> Acked-by: Kalle Valo <kvalo@...eaurora.org>

Thanks, will do!

greg k-h