linux-kernel - Re: [RFC v2-fix 1/1] x86/traps: Add #VE support for TDX guest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <867d1271-ff97-40b0-16a5-ccf875c0ad7b@intel.com>
Date:   Fri, 21 May 2021 12:15:09 -0700
From:   Dave Hansen <dave.hansen@...el.com>
To:     "Kuppuswamy, Sathyanarayanan" 
        <sathyanarayanan.kuppuswamy@...ux.intel.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Andy Lutomirski <luto@...nel.org>
Cc:     Tony Luck <tony.luck@...el.com>, Andi Kleen <ak@...ux.intel.com>,
        Kirill Shutemov <kirill.shutemov@...ux.intel.com>,
        Kuppuswamy Sathyanarayanan <knsathya@...nel.org>,
        Dan Williams <dan.j.williams@...el.com>,
        Raj Ashok <ashok.raj@...el.com>,
        Sean Christopherson <seanjc@...gle.com>,
        linux-kernel@...r.kernel.org,
        Sean Christopherson <sean.j.christopherson@...el.com>
Subject: Re: [RFC v2-fix 1/1] x86/traps: Add #VE support for TDX guest

On 5/21/21 11:45 AM, Kuppuswamy, Sathyanarayanan wrote:
> You have any other comments on this patch? If not, can you reply with your
> Reviewed-by tag?

Sathya, I've been rather busy with your own patches and your colleagues
TDX patches.  I've clearly communicated to you which patches I plan to
provide a review for.  I'll get to them, although not quite at the speed
you would like.

If you would like to get a quicker review, I'd highly suggest you go
find some of your TDX colleagues' code that needs its quality improved
and help by providing them reviews.  Reviews are a two-way street, not
just a service provided by maintainers to contributors.

You could also make good use of your time by going back over all of the
review comments I've made up to this point and doing a pass over your
work to ensure that I don't have to continue to repeat myself and waste
review efforts.  You could add a spell checker to your workflow, or
scripting to check for language conventions like avoiding "us" and "we".
 You could also seek out help to raise the quality of your
communications.  It isn't just reviewers that can help raise the quality
of your contributions.