linux-kernel - Re: [RFC PATCH v0.1 0/9] UMCG early preview/RFC patchset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87wnrrlwv0.fsf@meer.lwn.net>
Date:   Fri, 21 May 2021 13:17:55 -0600
From:   Jonathan Corbet <corbet@....net>
To:     Peter Oskolkov <posk@...gle.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-api <linux-api@...r.kernel.org>,
        Paul Turner <pjt@...gle.com>, Ben Segall <bsegall@...gle.com>,
        Peter Oskolkov <posk@...k.io>,
        Joel Fernandes <joel@...lfernandes.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Andrei Vagin <avagin@...gle.com>,
        Jim Newsome <jnewsome@...project.org>
Subject: Re: [RFC PATCH v0.1 0/9] UMCG early preview/RFC patchset

Peter Oskolkov <posk@...gle.com> writes:

> On Fri, May 21, 2021 at 8:08 AM Jonathan Corbet <corbet@....net> wrote:
>
> [...]
>> Documentation patches can help to guide that discussion; they also need
>> to be reviewed as well.  So yes, I think they should be present from the
>> beginning.  But then, that's the position I'm supposed to take :)  This
>> is a big change to the kernel's system-call API, I don't think that
>> there can be a proper discussion of that without a description of what
>> you're trying to do.
>
> Hi Jon,
>
> There are doc comments in patches 2 and 7 in umcg.c documenting the
> new syscalls. That said, I'll prepare a separate doc patch - I guess
> I'll add Documentation/scheduler/umcg.rst, unless you tell me there is
> a better place to do that. ETA mid-to-late next week.

Yes, I saw those; they are a bit terse at best.  What are the "worker
states"?  What's a "UMCG group"?  Yes, all this can be worked out by
pounding one's head against the code for long enough, but you're asking
a fair amount of your reviewers.

A good overall description would be nice, perhaps for the userspace-api
book.  But *somebody* is also going to have to write real man pages for
all these system calls; if you provided those, the result should be a
good description of how you expect this subsystem to work.

Thanks,

jon