linux-kernel - Re: [RFC v2-fix 1/1] x86/traps: Add #VE support for TDX guest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 21 May 2021 12:57:19 -0700
From:   "Kuppuswamy, Sathyanarayanan" 
        <sathyanarayanan.kuppuswamy@...ux.intel.com>
To:     Dave Hansen <dave.hansen@...el.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Andy Lutomirski <luto@...nel.org>
Cc:     Tony Luck <tony.luck@...el.com>, Andi Kleen <ak@...ux.intel.com>,
        Kirill Shutemov <kirill.shutemov@...ux.intel.com>,
        Kuppuswamy Sathyanarayanan <knsathya@...nel.org>,
        Dan Williams <dan.j.williams@...el.com>,
        Raj Ashok <ashok.raj@...el.com>,
        Sean Christopherson <seanjc@...gle.com>,
        linux-kernel@...r.kernel.org,
        Sean Christopherson <sean.j.christopherson@...el.com>
Subject: Re: [RFC v2-fix 1/1] x86/traps: Add #VE support for TDX guest

On 5/21/21 12:15 PM, Dave Hansen wrote:
> On 5/21/21 11:45 AM, Kuppuswamy, Sathyanarayanan wrote:
>> You have any other comments on this patch? If not, can you reply with your
>> Reviewed-by tag?
> 
> Sathya, I've been rather busy with your own patches and your colleagues
> TDX patches.  I've clearly communicated to you which patches I plan to
> provide a review for.  I'll get to them, although not quite at the speed
> you would like.
> 

My impression so far is, for TDX patch submissions, you usually reply to
the patch submission/comments in 1-2 days (sorry if this assumption is
incorrect). Since I did not see any major objections for this patch, I
was just checking with you to understand if this patch review is pending
due to something missing from my end. My intention was not to rush you,
but just to understand if it needs some work from my end.

Sorry if the reminder emails trouble you. Since we are aiming for v5.14
merge window, I am trying to avoid any delays from my end.

> If you would like to get a quicker review, I'd highly suggest you go
> find some of your TDX colleagues' code that needs its quality improved
> and help by providing them reviews.  Reviews are a two-way street, not
> just a service provided by maintainers to contributors.
> 
> You could also make good use of your time by going back over all of the
> review comments I've made up to this point and doing a pass over your
> work to ensure that I don't have to continue to repeat myself and waste
> review efforts.

I have considered your comments and fixed the common issues reported by
you in this patch-set. But when addressing recent comments and while
updating the commit log, some of these issues got introduced again. I will
try to avoid them in future.

-- 
Sathyanarayanan Kuppuswamy
Linux Kernel Developer