linux-kernel - Re: [PATCH v4 1/2] driver core: Move the "removable" attribute from USB to core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 21 May 2021 22:10:15 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Rajat Jain <rajatja@...gle.com>
Cc:     "Rafael J. Wysocki" <rafael@...nel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Alan Stern <stern@...land.harvard.edu>,
        linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org,
        linux-usb@...r.kernel.org, helgaas@...nel.org,
        Oliver Neukum <oneukum@...e.com>,
        David Laight <David.Laight@...lab.com>,
        Krzysztof Wilczyński <kw@...ux.com>,
        rajatxjain@...il.com, jsbarnes@...gle.com, dtor@...gle.com
Subject: Re: [PATCH v4 1/2] driver core: Move the "removable" attribute from
 USB to core

On Thu, May 13, 2021 at 04:27:00PM -0700, Rajat Jain wrote:
> Move the "removable" attribute from USB to core in order to allow it to be
> supported by other subsystem / buses. Individual buses that want to support
> this attribute can populate the removable property of the device while
> enumerating it with the 3 possible values -
>  - "unknown"
>  - "fixed"
>  - "removable"
> Leaving the field unchanged (i.e. "not supported") would mean that the
> attribute would not show up in sysfs for that device. The UAPI (location,
> symantics etc) for the attribute remains unchanged.
> 
> Signed-off-by: Rajat Jain <rajatja@...gle.com>
> ---
> v4: - instead of devicce_type->supports_removable, add 1 more value in
>       device_removable_enum
>     - documentation update.
>     - Remove "Acked-by" and "Reviewed-by" tags from previous versions.
> v3: - Minor commit log / comments updated.
>     - use sysfs_emit()
>     - Rename local variable name (state -> loc)
>     - change supports_removable flag from bool to bitfield.
> v2: Add documentation

This looks good to me, I have no further objection to it at all, nice
cleanups.

I can take this in my driver-core tree, so that other busses can use it
(and can create a tag to pull from if needed), or I can also take the
PCI patch (patch 2/2 here), if Bjorn gives his reviewed-by: for it.

Are there other busses besides PCI that you want to enable this soon
(i.e. before 5.14-rc1)?

thanks,

greg k-h