[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20210521233100.GB79835@rocinante.localdomain>
Date: Sat, 22 May 2021 01:31:00 +0200
From: Krzysztof WilczyĆski <kw@...ux.com>
To: Shradha Todi <shradha.t@...sung.com>
Cc: linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
jingoohan1@...il.com, gustavo.pimentel@...opsys.com,
lorenzo.pieralisi@....com, robh@...nel.org, bhelgaas@...gle.com,
pankaj.dubey@...sung.com, p.rajanbabu@...sung.com,
hari.tv@...sung.com, niyas.ahmed@...sung.com, l.mehra@...sung.com
Subject: Re: [PATCH 1/3] PCI: dwc: Add support for vendor specific capability
search
Hi Shradha,
[...]
> +u16 dw_pcie_find_vsec_capability(struct dw_pcie *pci, u8 vsec_cap)
> +{
> + u16 vsec = 0;
> + u32 header;
> +
> + while ((vsec = dw_pcie_find_next_ext_capability(pci, vsec,
> + PCI_EXT_CAP_ID_VNDR))) {
> + header = dw_pcie_readl_dbi(pci, vsec + PCI_VNDR_HEADER);
> + if (PCI_VNDR_HEADER_ID(header) == vsec_cap)
> + return vsec;
> + }
> +
> + return 0;
> +}
> +EXPORT_SYMBOL_GPL(dw_pcie_find_vsec_capability);
A small question as I am curious: why not use pci_find_vsec_capability()
here? The implementation looks very similar, which is why I am asking,
but it might be that I am missing something, and for that I apologise in
advance.
Krzysztof
Powered by blists - more mailing lists