linux-kernel - Re: [PATCH v3] bcache: avoid oversized read request in cache missing code path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fea14938-8347-d549-4a2a-4f1810e02bf7@suse.de>
Date:   Fri, 21 May 2021 11:30:08 +0800
From:   Coly Li <colyli@...e.de>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     linux-bcache@...r.kernel.org, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Kent Overstreet <kent.overstreet@...il.com>
Subject: Re: [PATCH v3] bcache: avoid oversized read request in cache missing
 code path

On 5/20/21 4:05 PM, Christoph Hellwig wrote:
> This fix is pretty gross.  Adding pages to bios can fail for all kinds
> of reasons, so the fix is to use bio_add_page and check its return
> value, and if it needs another bio keep looping and chaining more bios.
> 

OK, I will try this idea and avoid to access BIO_MAX_VECS directly.

> And maybe capping the readahead to some sane upper bound still makes
> sense, but it should never look at BIO_MAX_VECS for that.
> 

Thanks for the hint.

Coly Li