linux-kernel - RE: [PATCH V2 03/18] ARM: dts: imx7ulp: add the missing lpi2c ipg clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM6PR04MB4966DA92D3ADD6D72273DCAB80299@AM6PR04MB4966.eurprd04.prod.outlook.com>
Date:   Fri, 21 May 2021 06:17:57 +0000
From:   Aisheng Dong <aisheng.dong@....com>
To:     Clark Wang <xiaoning.wang@....com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>
CC:     "kernel@...gutronix.de" <kernel@...gutronix.de>,
        dl-linux-imx <linux-imx@....com>,
        "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH V2 03/18] ARM: dts: imx7ulp: add the missing lpi2c ipg
 clock

> From: Clark Wang <xiaoning.wang@....com>
> Sent: Tuesday, April 6, 2021 7:33 PM
> 
> The lpi2c driver has add the missing ipg clock.

Pls drop this line as binding is not decided by driver 

> So add the ipg clock here for all lpi2c nodes.

Per clock?

Maybe better refined as add the missing per clock ....

> 
> Signed-off-by: Clark Wang <xiaoning.wang@....com>
> ---
> V2 changes:
>  - New patch added in V2
> ---
>  arch/arm/boot/dts/imx7ulp.dtsi | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx7ulp.dtsi b/arch/arm/boot/dts/imx7ulp.dtsi
> index b7ea37ad4e55..eb0d4b8f624d 100644
> --- a/arch/arm/boot/dts/imx7ulp.dtsi
> +++ b/arch/arm/boot/dts/imx7ulp.dtsi
> @@ -328,8 +328,9 @@ lpi2c6: i2c@...40000 {
>  			compatible = "fsl,imx7ulp-lpi2c";
>  			reg = <0x40a40000 0x10000>;
>  			interrupts = <GIC_SPI 36 IRQ_TYPE_LEVEL_HIGH>;
> -			clocks = <&pcc3 IMX7ULP_CLK_LPI2C6>;
> -			clock-names = "ipg";
> +			clocks = <&pcc3 IMX7ULP_CLK_LPI2C6>,
> +				 <&scg1 IMX7ULP_CLK_NIC1_BUS_DIV>;
> +			clock-names = "per", "ipg";
>  			assigned-clocks = <&pcc3 IMX7ULP_CLK_LPI2C6>;
>  			assigned-clock-parents = <&scg1 IMX7ULP_CLK_FIRC>;
>  			assigned-clock-rates = <48000000>;
> @@ -340,8 +341,9 @@ lpi2c7: i2c@...50000 {
>  			compatible = "fsl,imx7ulp-lpi2c";
>  			reg = <0x40a50000 0x10000>;
>  			interrupts = <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>;
> -			clocks = <&pcc3 IMX7ULP_CLK_LPI2C7>;
> -			clock-names = "ipg";
> +			clocks = <&pcc3 IMX7ULP_CLK_LPI2C7>,
> +				 <&scg1 IMX7ULP_CLK_NIC1_BUS_DIV>;
> +			clock-names = "per", "ipg";
>  			assigned-clocks = <&pcc3 IMX7ULP_CLK_LPI2C7>;
>  			assigned-clock-parents = <&scg1 IMX7ULP_CLK_FIRC>;
>  			assigned-clock-rates = <48000000>;
> --
> 2.25.1