linux-kernel - Re: [PATCH 11/16] i2c: busses: i2c-pnx: Provide descriptions for 'alg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 21 May 2021 09:24:44 +0300
From:   Vladimir Zapolskiy <vz@...ia.com>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     linux-kernel@...r.kernel.org,
        Dennis Kovalev <dkovalev@...mvista.com>,
        Vitaly Wool <vwool@...mvista.com>,
        linux-arm-kernel@...ts.infradead.org, linux-i2c@...r.kernel.org
Subject: Re: [PATCH 11/16] i2c: busses: i2c-pnx: Provide descriptions for
 'alg_data' data structure

Hi Lee,

On 5/20/21 10:01 PM, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
> 
>   drivers/i2c/busses/i2c-pnx.c:147: warning: Function parameter or member 'alg_data' not described in 'i2c_pnx_start'
>   drivers/i2c/busses/i2c-pnx.c:147: warning: Excess function parameter 'adap' description in 'i2c_pnx_start'
>   drivers/i2c/busses/i2c-pnx.c:202: warning: Function parameter or member 'alg_data' not described in 'i2c_pnx_stop'
>   drivers/i2c/busses/i2c-pnx.c:202: warning: Excess function parameter 'adap' description in 'i2c_pnx_stop'
>   drivers/i2c/busses/i2c-pnx.c:231: warning: Function parameter or member 'alg_data' not described in 'i2c_pnx_master_xmit'
>   drivers/i2c/busses/i2c-pnx.c:231: warning: Excess function parameter 'adap' description in 'i2c_pnx_master_xmit'
>   drivers/i2c/busses/i2c-pnx.c:301: warning: Function parameter or member 'alg_data' not described in 'i2c_pnx_master_rcv'
>   drivers/i2c/busses/i2c-pnx.c:301: warning: Excess function parameter 'adap' description in 'i2c_pnx_master_rcv'
> 
> Cc: Vladimir Zapolskiy <vz@...ia.com>
> Cc: Dennis Kovalev <dkovalev@...mvista.com>
> Cc: Vitaly Wool <vwool@...mvista.com>
> Cc: linux-arm-kernel@...ts.infradead.org
> Cc: linux-i2c@...r.kernel.org
> Signed-off-by: Lee Jones <lee.jones@...aro.org>

thank you for the change, it's obviously correct.

Acked-by: Vladimir Zapolskiy <vz@...ia.com>

--
Best wishes,
Vladimir