linux-kernel - Re: [PATCH 03/16] i2c: busses: i2c-ali1563: File headers are not good candidates for kernel-doc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210521120619.503cb7d9@endymion>
Date:   Fri, 21 May 2021 12:06:19 +0200
From:   Jean Delvare <jdelvare@...e.de>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     linux-kernel@...r.kernel.org, Rudolf Marek <r.marek@...embler.cz>,
        linux-i2c@...r.kernel.org
Subject: Re: [PATCH 03/16] i2c: busses: i2c-ali1563: File headers are not
 good candidates for kernel-doc

Hi Lee,

On Thu, 20 May 2021 20:00:52 +0100, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/i2c/busses/i2c-ali1563.c:24: warning: expecting prototype for i2c(). Prototype was for ALI1563_MAX_TIMEOUT() instead

Thanks for taking care of the warnings. I agree that a clean W=1 build
would be very nice to have.

> Cc: Jean Delvare <jdelvare@...e.com>
> Cc: Rudolf Marek <r.marek@...embler.cz>
> Cc: linux-i2c@...r.kernel.org
> Signed-off-by: Lee Jones <lee.jones@...aro.org>
> ---
>  drivers/i2c/busses/i2c-ali1563.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/busses/i2c-ali1563.c b/drivers/i2c/busses/i2c-ali1563.c
> index 4d12e3da12f0d..55a9e93fbfeb5 100644
> --- a/drivers/i2c/busses/i2c-ali1563.c
> +++ b/drivers/i2c/busses/i2c-ali1563.c
> @@ -1,5 +1,5 @@
>  // SPDX-License-Identifier: GPL-2.0-only
> -/**
> +/*
>   *	i2c-ali1563.c - i2c driver for the ALi 1563 Southbridge
>   *
>   *	Copyright (C) 2004 Patrick Mochel

Reviewed-by: Jean Delvare <jdelvare@...e.de>

-- 
Jean Delvare
SUSE L3 Support