linux-kernel - Re: [PATCH v2 1/3] gpio: regmap: Support few IC specific operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ff905a32b736a0b03fb4c74b7e876c764a561106.camel@fi.rohmeurope.com>
Date:   Fri, 21 May 2021 10:25:19 +0000
From:   "Vaittinen, Matti" <Matti.Vaittinen@...rohmeurope.com>
To:     "andy.shevchenko@...il.com" <andy.shevchenko@...il.com>,
        "michael@...le.cc" <michael@...le.cc>
CC:     linux-power <linux-power@...rohmeurope.com>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "bgolaszewski@...libre.com" <bgolaszewski@...libre.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linus.walleij@...aro.org" <linus.walleij@...aro.org>
Subject: Re: [PATCH v2 1/3] gpio: regmap: Support few IC specific operations


On Fri, 2021-05-21 at 12:19 +0200, Michael Walle wrote:
> Am 2021-05-21 12:09, schrieb Andy Shevchenko:
> > On Fri, May 21, 2021 at 12:53 PM Matti Vaittinen
> > <matti.vaittinen@...rohmeurope.com> wrote:
> > > Changelog v2: (based on suggestions by Michael Walle)
> > >   - drop gpio_regmap_set_drvdata()
> > 
> > But why do we have gpio_regmap_get_drvdata() and why is it
> > different
> > now to the new member handling?
> 
> Eg. the reg_mask_xlate() callback is just passed a "struct 
> gpio_regmap*".
> If someone needs to access private data there,
> gpio_regmap_get_drvdata()
> is used. At least that was its intention.

I would help the IC driver here too and just directly provide the
drvdata pointer as argument. I don't see much value in providing the
regmap_gpio pointer as IC driver can not dereference it.

> 
> Thus I was also suggesting to use "struct gpio_regmap*" in the newer
> callbacks.
> 
> I don't get what you mean by "different to the new member handling"?
> 
> -michael