linux-kernel - Re: [PATCH 0/2] Remove GA14/15 quirks to acpi/video

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <6HDGTQ.I5W09JQ0U6UN@ljones.dev>
Date:   Fri, 21 May 2021 22:36:42 +1200
From:   Luke Jones <luke@...nes.dev>
To:     Hans de Goede <hdegoede@...hat.com>
Cc:     corentin.chary@...il.com, acpi4asus-user@...ts.sourceforge.net,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/2] Remove GA14/15 quirks to acpi/video_detect

Oh, thanks Hans. I wasn't sure how a git revert was meant to work and 
assumed that
whatever git did was fine.

I am absolutely happy for you to take care of those issues and push 
ahead.

Many thanks!

On Fri, May 21 2021 at 12:24:13 +0200, Hans de Goede 
<hdegoede@...hat.com> wrote:
> Hi Luke,
> 
> On 4/19/21 9:49 AM, Luke D. Jones wrote:
>>  Revert two commits to allow a patch to acpi/video_detect to 
>> correctly
>>  set the backlight control as native.
>> 
>>  Luke D. Jones (2):
>>    Revert "platform/x86: asus-nb-wmi: Drop duplicate DMI quirk
>>      structures"
>>    Revert "platform/x86: asus-nb-wmi: add support for ASUS ROG 
>> Zephyrus
>>      G14 and G15"
> 
> Thank you, since the matching drivers/acpi/video_detect.c have been 
> merged
> by Rafael, I've added these to my review-hans branch now.
> 
> But there is one problem, these miss a:
> 
> Signed-off-by: Luke D. Jones <luke@...nes.dev>
> 
> In their commit message, I assume this was an oversight, so I've added
> this. If you can let me know if this is ok, then I can push these to
> for-next.
> 
> I've also rewritten the commit messages to explain why things are 
> being
> reverted, see:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
> 
> Regards,
> 
> Hans
>