linux-kernel - Re: [PATCH] This commit fixes the error generated due to the wrong indentation which does not follow the codding style norms set by Linux-kernel and space- bar is used in place of tab to give space which causes a visual error for some compilers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210521144128.052e3c48@gmail.com>
Date:   Fri, 21 May 2021 14:41:28 +0300
From:   Pavel Skripkin <paskripkin@...il.com>
To:     Aviral Gupta <shiv14112001@...il.com>
Cc:     viro@...iv.linux.org.uk, shuah@...nal.org,
        linux-fsdevel@...r.kernel.org,
        linux-kernel-mentees@...ts.linuxfoundation.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] This commit fixes the error generated due to the wrong
 indentation which does not follow the codding style norms set by
 Linux-kernel and space- bar is used in place of tab to give space which
 causes a visual error for some compilers

On Fri, 21 May 2021 16:26:54 +0530
Aviral Gupta <shiv14112001@...il.com> wrote:

> ERROR: switch and case should be at the same indent
> +	switch (whence) {
> +		case 1:
> [...]
> +		case 0:
> [...]
> +		default:
> ERROR: code indent should use tabs where possible
> +                              void (*callback)(struct dentry *))$
> 
> Signed-off-by: Aviral Gupta <shiv14112001@...il.com>
> ---
>  fs/libfs.c | 20 ++++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)
> 

Hi, Aviral!

Always check your patches with ./scripts/checpatch.pl. It will warn You
if your patch has common errors (ex: too long subject line like yours). 

I think, this link might be helpful
https://www.kernel.org/doc/html/latest/process/submitting-patches.html.
This document contains canonical patch format and other useful
info about "how to send patches".

Goog luck! 


With regards,
Pavel Skripkin